[RFC PATCH 5/5] audit: use audit_set_enabled() in audit_enable()

Paul Moore pmoore at redhat.com
Fri Sep 1 13:45:05 UTC 2017


From: Paul Moore <paul at paul-moore.com>

Use audit_set_enabled() to enable auditing during early boot.  This
obviously won't emit an audit change record, but it will work anyway
and should help prevent in future problems by consolidating the
enable/disable code in one function.

Signed-off-by: Paul Moore <paul at paul-moore.com>
---
 kernel/audit.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/audit.c b/kernel/audit.c
index 01bf1e479a8c..842237f5182b 100644
--- a/kernel/audit.c
+++ b/kernel/audit.c
@@ -1574,8 +1574,8 @@ static int __init audit_enable(char *str)
 
 	if (audit_default == AUDIT_OFF)
 		audit_initialized = AUDIT_DISABLED;
-	audit_enabled = audit_default;
-	audit_ever_enabled = !!audit_enabled;
+	if (audit_set_enabled(audit_default))
+		panic("audit: error setting audit state (%d)\n", audit_default);
 
 	pr_info("%s\n", audit_default ?
 		"enabled (after initialization)" : "disabled (until reboot)");




More information about the Linux-audit mailing list