[PATCH 07/10] audit: Remove pointless check in insert_hash()

Paul Moore paul at paul-moore.com
Fri Jul 27 04:47:33 UTC 2018


On Tue, Jul 10, 2018 at 6:02 AM Jan Kara <jack at suse.cz> wrote:
>
> The audit_tree_group->mark_mutex is held all the time while we create
> the fsnotify mark, add it to the inode, and insert chunk into the hash.
> Hence mark cannot get detached during this time and so the check whether
> the mark is attached in insert_hash() is pointless.
>
> Signed-off-by: Jan Kara <jack at suse.cz>
> ---
>  kernel/audit_tree.c | 2 --
>  1 file changed, 2 deletions(-)

This makes sense.

--
paul moore
www.paul-moore.com




More information about the Linux-audit mailing list