[PATCH v2] audit: report audit wait metric in audit status reply

Steve Grubb sgrubb at redhat.com
Fri Dec 4 02:47:40 UTC 2020


On Thursday, December 3, 2020 9:16:52 PM EST Paul Moore wrote:
> > > > Author:     Richard Guy Briggs <rgb at redhat.com>
> > > > AuthorDate: 2014-11-17 15:51:01 -0500
> > > > Commit:     Paul Moore <pmoore at redhat.com>
> > > > CommitDate: 2014-11-17 16:53:51 -0500
> > > > ("audit: convert status version to a feature bitmap")
> > > > It was introduced specifically to enable distributions to selectively
> > > > backport features.  It was converted away from AUDIT_VERSION.
> > > > 
> > > > There are other ways to detect the presence of
> > > > backlog_wait_time_actual
> > > > as I mentioned above.
> > > 
> > > Let me be blunt - I honestly don't care what Steve's audit userspace
> > > does to detect this.  I've got my own opinion, but Steve's audit
> > > userspace is not my project to manage and I think we've established
> > > over the years that Steve and I have very different views on what
> > > constitutes good design.
> > 
> > And guessing what might be in buffers of different sizes is good design?
> > The FEATURE_BITMAP was introduced to get rid of this ambiguity.
> 
> There is just soo much to unpack in your comment Steve, but let me
> keep it short ...
> 
> - This is an enterprise distro problem, not an upstream problem.  The
> problems you are talking about are not a problem for upstream.

You may look at it that way. I do not. Audit -userspace is also an upstream 
for a lot of distros and I need to make this painless for them. So, while you 
may think of this being a backport problem for Red Hat to solve, I think of 
this as a generic problem that I'd like to solve for Debian, Suse, Ubuntu, 
Arch, Gentoo, anyone using audit. We both are upstream.

-Steve





More information about the Linux-audit mailing list