[PATCH] audit: fix undefined behavior in bit shift for AUDIT_BIT

Paul Moore paul at paul-moore.com
Sat Nov 5 04:25:41 UTC 2022


On Mon, Oct 31, 2022 at 7:50 AM cuigaosheng <cuigaosheng1 at huawei.com> wrote:
> > Thanks, this patch looks good, although the 'Fixes:' line above isn't
> > correct.  The commit you reference may be the commit which created
> > AUDIT_BIT in include/uapi/linux/audit.h, but before that it was
> > defined in include/linux/audit.h with the original implementation
> > shipping in v2.6.6-rc1.  As the original AUDIT_BIT implementation
> > predates git itself, I would suggest removing the 'Fixes' line
> > entirely and I'll simply add the usual stable marking when I merge it
> > into audit/stable-6.1.  If that is okay with you I'll go ahead and
> > merge this patch which that tweak - is that okay?
>
> Yes, you are right, thanks for taking time to review this patch!

You're welcome, thanks for the fix :)

I just merged this into audit/stable-6.1 and I'll send this up to
Linus next week.

-- 
paul-moore.com



More information about the Linux-audit mailing list