On Wed, Mar 08, 2006 at 07:22:50PM +1100, Nick Piggin wrote: > Also: I might be talking complete crap here, so anyone feel free to ridicule > me if I'm wrong. No, the smb_rmb() is unnecessary. akpm was the only one who thought we needed it originally, it just somehow stayed into this iteration of the patch.