[Linux-cachefs] [PATCH 0/2] Fscache cleanup and fix

[Milosz Tanski]

David,

I wanted to follow on this since I haven't heard any comments on this
in the last few weeks. I imagine that you were on vacation in August.

Best,
- Milosz

On Tue, Aug 27, 2013 at 7:35 PM, Sage Weil <sage at inktank.com> wrote:
> Thanks, Milosz!
>
> I've pulled these into the testing branch and squashed them into the
> existing commits.
>
> David, I'm still not sure whether the fscache patches should go in through
> the Ceph tree or via your tree; either way I think they need your ACK.
>
> https://github.com/ceph/ceph-client/commit/e78fae9b8e0e762114df0cbe718a2ad7c49a18e7
> https://github.com/ceph/ceph-client/commit/8151f62a34cc01c9de040722aa7eff85f3092156
> https://github.com/ceph/ceph-client/commit/341158ee87d950f2bcf73e56d0db7b57bbe500a7
>
> Thanks!
> sage
>
>
> On Tue, 27 Aug 2013, Milosz Tanski wrote:
>
>> Sage,
>>
>> These are the changes you requested. I eliminated the use of ifdefs in the C
>> code. It's all self contained in cache.[ch] and in the case of it being
>> disabled becomes a nop.
>>
>> Also, I found a small bug where we would not free the invalidate queue on
>> unmount. It's split into it's own commit.
>>
>> Finally, I saw that you had a hard time building it without the kernel flag
>> enabled. So I made sure to test a config with fscache for Ceph disabled right
>> before sping things.
>>
>> The commits are from my branch (which is based on top of the main testing
>> branch) from my repo:
>>
>>     https://adfin@bitbucket.org/adfin/linux-fs.git branch: wip-ceph-fscache
>>
>> Best,
>> - Milosz
>>
>> Milosz Tanski (2):
>>   ceph: Do not leak fscache workqueue
>>   ceph: fscache cleanup
>>
>>  fs/ceph/cache.c | 90 ++++++++++++++++++++++++++++++++++++++++++++++++++-------
>>  fs/ceph/cache.h | 68 +++++++++++++++++++------------------------
>>  fs/ceph/inode.c | 61 +-------------------------------------
>>  fs/ceph/super.c | 22 ++++----------
>>  fs/ceph/super.h |  1 -
>>  5 files changed, 115 insertions(+), 127 deletions(-)
>>
>> --
>> 1.8.1.2
>>
>>