[Linux-cachefs] [PATCH 2/4] fscache: Fix race in fscache_op_complete() due to split atomic_sub & read

Andrea Parri andrea.parri at amarulasolutions.com
Wed Nov 28 20:45:23 UTC 2018


> > Sure.  My point was: those operations are currently not atomic _and_
> > they provide no ordering; I think that the above commit message does
> > a good work in explaining *why* we need atomicity, but can't say the
> > same for the memory-ordering requirement.
> 
> Having discussed it with Paul McKenney and thought about it some more, I think
> relaxed is probably okay since there isn't a pair of variables that need
> ordering.

Count several troubled, and exiting!, weekends spent "processing" (my)
conversations with Paul...  so been there! ;-)

Makes all sense to me of course, thank you for the clarification.

  Andrea


> 
> David




More information about the Linux-cachefs mailing list