[Linux-cachefs] [PATCH 11/12] fscache: Fix fscache_cookie_put() to not deref after dec

David Howells dhowells at redhat.com
Wed Aug 25 14:05:51 UTC 2021


Jeff Layton <jlayton at redhat.com> wrote:

> > fscache_cookie_put() accesses the cookie it has just put inside the
> > tracepoint that monitors the change - but this is something it's not
> > allowed to do if we didn't reduce the count to zero.
> 
> Do you mean "if the count went to zero." ?

No.  If *we* reduced the count to zero, it falls to us to destroy the object,
so we're allowed to look into it again.

If we didn't reduce the count to zero, then someone else might destroy it
before we look into it again.

David




More information about the Linux-cachefs mailing list