[Linux-cachefs] [RFC PATCH] cifs: Transition from ->readpages() to ->readahead()
David Howells
dhowells at redhat.com
Mon Jan 24 15:46:27 UTC 2022
Matthew Wilcox <willy at infradead.org> wrote:
> > Would it be possible to make readahead_count() do:
> >
> > return rac->_nr_pages - rac->_batch_count;
> >
> > maybe?
>
> Yes, I think that would make sense. Do we also need to change
> readhead_length()? It seems to me that it's only ever called once at
> initialisation, so it should be possible to keep the two in sync.
> Can you write & test such a patch? I'll support it going upstream
> (either by taking it myself or giving you a R-b to take it through your
> tree).
It seems I also have a problem with readahead_index() needing compensation
too. I'm guessing that's more of a problem, however, as I think that's
expected to refer to the beginning of the current batch.
David
More information about the Linux-cachefs
mailing list