[Linux-cachefs] [PATCH V5 2/5] cachefiles: extract ondemand info field from cachefiles_object

David Howells dhowells at redhat.com
Fri Apr 14 13:51:31 UTC 2023


Jia Zhu <zhujia.zj at bytedance.com> wrote:

>  #define CACHEFILES_OBJECT_STATE_FUNCS(_state, _STATE)	\
>  static inline bool								\
>  cachefiles_ondemand_object_is_##_state(const struct cachefiles_object *object) \
>  {												\
> -	return object->state == CACHEFILES_ONDEMAND_OBJSTATE_##_STATE; \
> +	return object->ondemand->state == CACHEFILES_ONDEMAND_OBJSTATE_##_STATE; \
>  }												\
>  												\
>  static inline void								\
>  cachefiles_ondemand_set_object_##_state(struct cachefiles_object *object) \
>  {												\
> -	object->state = CACHEFILES_ONDEMAND_OBJSTATE_##_STATE; \
> +	object->ondemand->state = CACHEFILES_ONDEMAND_OBJSTATE_##_STATE; \
>  }

I wonder if those need barriers - smp_load_acquire() and smp_store_release().

David


More information about the Linux-cachefs mailing list