[Linux-cluster] Bufferoverrun in cman_tool/join.c

[Rick Stevens]

Patrick Caulfield wrote:
> On Wed, Mar 16, 2005 at 11:46:38AM +0100, Michael Stübiger wrote:
> 
>>Hello!
>>
>>The buffersize of 512 as defined in cman_tool/join.c seems to be insufficient in some cases.
>>When I tried to add a node with a FQDN of 42 characters in length to the cluster I got the following
>>error message:
>>
>>can't resolve node name <nodename>
>>
>>Since DNS was working correctly both ways the message was plainly missleading.
>>Strace'ing a join showed that gethostbyname2_r exited with an error number indicating a bufferoverrun.
>>
>>Changing the buffersize to 1024 solved the Problem in this case.
>>
> 
> 
> Thanks, I'll change that in CVS.  I'll also get it to print the real error in
> case gethostbyname2_r fails for any other reason.

Also be aware that any given component in a FQDN can be up to 65
characters in length (can't recall which RFC defines that, but it's
bitten me before as well).
----------------------------------------------------------------------
- Rick Stevens, Senior Systems Engineer     rstevens at vitalstream.com -
- VitalStream, Inc.                       http://www.vitalstream.com -
-                                                                    -
-        Brain:  The organ with which we think that we think.        -
----------------------------------------------------------------------