[Linux-cluster] Updating fence scripts

[James Parsons]

BERES Laszlo wrote:

>Maciej Bogucki wrote:
>
>  
>
>>If You doesn't have test environment then I suggest You to do tests in
>>production to check if everything is working as You expected.
>>    
>>
>
>Thanks, but my question was somehow explicit about fencing :)
>
>  
>
>>But, if there is no change in fence_xxx script You don't need to do
>>fence testing.
>>    
>>
>
>There is a change in fence_ilo script, I have to upgrade it.
>
>  
>
If you are referring to the 5.1 beta build, or the 4.5 asynchronous 
update, the change to fence_ilo is a minor fix to support ilo2...if you 
are running ilo currently with no problems, it is very highly extremely 
unlikely ;), that you will encounter a problem. Still, as the man says, 
you should test to be certain...as failed fencing when you need it is a 
VERY bad thing.

Here is what changed, btw...
---------------------------------------------------------------------------------

--- cluster/fence/agents/ilo/fence_ilo.pl	2007/04/09 15:22:39	1.3.2.3.2.1
+++ cluster/fence/agents/ilo/fence_ilo.pl	2007/07/17 18:38:59	1.3.2.3.2.2
@@ -279,10 +279,13 @@
 
 	foreach my $line (@response)
 	{
+		if ($line =~ /FIRMWARE_VERSION\s*=\s*\"(.*)\"/) {
+			$firmware_rev = $1;
+		}
 		if ($line =~ /MANAGEMENT_PROCESSOR\s*=\s*\"(.*)\"/) {
 			if ($1 eq "iLO2") {
 				$ilo_vers = 2;
-				print "power_status: reporting iLO2\n" if ($verbose);
+				print "power_status: reporting iLO2 $firmware_rev\n" if ($verbose);
 			}
 		}
 
@@ -358,7 +361,11 @@
 		# HOLD_PWR_BUTTON is used to power the machine off, and
 		# PRESS_PWR_BUTTON is used to power the machine on;
 		# when the power is off, HOLD_PWR_BUTTON has no effect.
-		sendsock $socket, "<HOLD_PWR_BTN/>\n";
+		if ($firmware_rev > 1.29) {
+			sendsock $socket, "<HOLD_PWR_BTN TOGGLE=\"Yes\" />\n";
+		} else {
+			sendsock $socket, "<HOLD_PWR_BTN/>\n";
+		}
 	}
 	# As of firmware version 1.71 (RIBCL 2.21) The SET_HOST_POWER command
 	# is no longer available.  HOLD_PWR_BTN and PRESS_PWR_BTN are used 
@@ -515,6 +522,7 @@
 $action = "reboot";
 $ribcl_vers = undef; # undef = autodetect
 $ilo_vers = 1;
+$firmware_rev = 0;