[Linux-cluster] cvs stable won't compile

[Wendy Cheng]

Ivan Pantovic wrote:

>
> It seems that latest STABLE CVS won't compile.
>
> it is probably sneaked in regarding Bugzilla 216209 code change but 
> now we have an undeclared 'iocb'

Yeah, very likely - I never added Asynchronous IO (AIO) code into 
branches other than RHELs. And the fix of 216209 was built on top of 
AIO. Sorry about that. I'll remove it when I get to office first thing 
tomorrow morning (it is about midnight here now).

For now, you can safely remove the following if statement without 
affecting code correctness.

                /* for asynchronous IO, the buffer can not be splitted */
                if (iocb) {
                        count = do_write_direct_alloc(file, buf, size, 
offset, iocb);
                        goto out_iocb_write;
                }

-- Wendy

>
>> /var/tmp/portage/gfs-kernel-1.03.00-r1/work/cluster-1.03.00/gfs-kernel/src/gfs/ops_file.c: 
>> In function `do_write_direct':
>> /var/tmp/portage/gfs-kernel-1.03.00-r1/work/cluster-1.03.00/gfs-kernel/src/gfs/ops_file.c:652: 
>> error: `iocb' undeclared (first use in this function)
>> /var/tmp/portage/gfs-kernel-1.03.00-r1/work/cluster-1.03.00/gfs-kernel/src/gfs/ops_file.c:652: 
>> error: (Each undeclared identifier is reported only once
>> /var/tmp/portage/gfs-kernel-1.03.00-r1/work/cluster-1.03.00/gfs-kernel/src/gfs/ops_file.c:652: 
>> error: for each function it appears in.)
>> /var/tmp/portage/gfs-kernel-1.03.00-r1/work/cluster-1.03.00/gfs-kernel/src/gfs/ops_file.c:653: 
>> error: too many arguments to function `do_write_direct_alloc'
>> make[2]: *** 
>> [/var/tmp/portage/gfs-kernel-1.03.00-r1/work/cluster-1.03.00/gfs-kernel/src/gfs/ops_file.o] 
>> Error 1
>> make[1]: *** 
>> [_module_/var/tmp/portage/gfs-kernel-1.03.00-r1/work/cluster-1.03.00/gfs-kernel/src/gfs] 
>> Error 2
>> make[1]: Leaving directory `/usr/src/linux-2.6.18-gentoo-r5'
>> make: *** [all] Error 2
>
>
> Best regards.
>