[Linux-cluster] make errors for 2.6.19 on fc6

[Robert Peterson]

nirmal tom wrote:
> hi,
> Thanks a lot to both Sridhar and Rafael.Now gfs-kernel stucks, i think.
> 
> /opt/cluster/gfs-kernel/src/gfs/glock.c:41: error: field ‘gr_work’ has 
> incomplete type
> /opt/cluster/gfs-kernel/src/gfs/glock.c: In function ‘greedy_work’:
> /opt/cluster/gfs-kernel/src/gfs/glock.c:1762: warning: type defaults to 
> ‘int’ in declaration of ‘__mptr’
> /opt/cluster/gfs-kernel/src/gfs/glock.c:1762: warning: initialization 
> from incompatible pointer type
> /opt/cluster/gfs-kernel/src/gfs/glock.c: In function ‘gfs_glock_be_greedy’:
> /opt/cluster/gfs-kernel/src/gfs/glock.c:1817: error: implicit 
> declaration of function ‘INIT_DELAYED_WORK’
> make[5]: *** [/opt/cluster/gfs-kernel/src/gfs/glock.o] Error 1
> make[4]: *** [_module_/opt/cluster/gfs-kernel/src/gfs] Error 2
> make[4]: Leaving directory `/usr/src/kernels/2.6.19-1.2911.fc6-i686'
> make[3]: *** [all] Error 2
> make[3]: Leaving directory `/opt/cluster/gfs-kernel/src/gfs'
> make[2]: *** [all] Error 2
> make[2]: Leaving directory `/opt/cluster/gfs-kernel/src'
> make[1]: *** [all] Error 2
> make[1]: Leaving directory `/opt/cluster/gfs-kernel'
> make: *** [all] Error 2
> 
> 
> on both stable and development, i got this.how to fix this one?
> 
> thanks and regards,
> Nirmal Tom.

Hi Nirmal,

This has to do with changes made to the upstream kernels, which our STABLE
and HEAD branches of CVS track.  In 2.6.19, the "struct delayed_work" was 
"struct work_struct" and "INIT_DELAYED_WORK" was "INIT_WORK".
There was also a change in what was passed.  The following diff shows the 
change made to bring glock.c up to the newer kernels (HEAD branch):

http://sources.redhat.com/cgi-bin/cvsweb.cgi/cluster/gfs-kernel/src/gfs/glock.c.diff?r1=1.30&r2=1.31&cvsroot=cluster&f=h

If you really don't want to upgrade to a newer kernel, you could back out 
the last change I did, at least to glock.c.  To compare them, also see:

http://sources.redhat.com/cgi-bin/cvsweb.cgi/cluster/gfs-kernel/src/gfs/glock.c?cvsroot=cluster

Regards,

Bob Peterson
Red Hat Cluster Suite