[Linux-cluster] Fwd: fence-agent : ipmilan : power_wait : missing in ipmi_off.

Fri Feb 3 18:07:14 UTC 2012

Hi Christine, all,

This is definitely true.

I do not have so nice patches against git master, but I'd like to
present my patches against 3.1.7 which I use for a quite long time (I
send them as I promised year ago or so on pacemaker list).

I attach them in order they are applied in my srpm, and I hope that
their names and contents are self-describing. If not please do not
hesitate to write me.

I would describe some patches here:

01-fence-agents-3.1.7-ipmilan-uniq.patch fixes parameter uniqueness
report (needed for newer pacemaker)

02-fence-agents-3.1.2-ipmilan-cycle.patch fixes return value for cycle
method (nobody uses it yet?)

06-fence-agents-3.1.7-ipmilan-reset-method.patch just adds IPMI reset
method, because some IPMI controllers have bugs in cycle or on-off
implementations and admin may want to use reset which always work with
them.

08-fence-agents-3.1.7-ipmilan-force-ops.patch and
09-fence-agents-3.1.7-ipmilan-status-recheck.patch add more workarounds
against buggy IPMI controllers which may report status incorrectly right
after operation is completed (Supermicro on-board ones are examples of
them).

I definitely do not like amount of function arguments I have after that
all, but it is better to leave it to package maintainer to decide what
to do with them

Pleas do not kick me for sending non-git patches, it is over my skills
to do that.

Best,
Vladislav

03.02.2012 17:22, Christine Caulfield wrote:
> 
> 
> -------- Original Message --------
> Subject: fence-agent : ipmilan : power_wait : missing in ipmi_off.
> Date: Fri, 03 Feb 2012 15:20:47 +0100 (CET)
> From: Alexandre DERUMIER <aderumier at odiso.com>
> To: ccaulfie at redhat.com
> 
> Hi,
> 
> I'm working to implement a redhat cluster  and I think I found a bug in
> ipmilan.c
> 
> On this commit:
> 
> fence-agents: Add power_wait to fence_ipmilan
> 
> http://git.fedorahosted.org/git/?p=fence-agents.git;a=commitdiff;h=7d53eb8ab06a8713d2b52500da741b6170fbfc91
> 
> 
> in ipmi_off , the sleep(2) is still hardcorded
> 
> I think It must replace with  sleep(ipmi->i_power_wait), like ipmi_on ?
> 
> 
> index 52be371..46814a8 100644
> --- a/fence/agents/ipmilan/ipmilan.c
> +++ b/fence/agents/ipmilan/ipmilan.c
> @@ -473,7 +473,7 @@ ipmi_off(struct ipmi *ipmi)
>                 if (ret != 0)
>                         return ret;
> 
> -               sleep(2);
> +               sleep(ipmi->i_power_wait);
>                 --retries;
>                 ret = ipmi_op(ipmi, ST_STATUS, power_status);
> 
> 
> 
> What do you thinks about it ?
> 
> 
> 
> Best Regards,
> 
> Alexandre Derumier
> System Engineer
> aderumier at odiso.com
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> -- 
> Linux-cluster mailing list
> Linux-cluster at redhat.com
> https://www.redhat.com/mailman/listinfo/linux-cluster

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 01-fence-agents-3.1.7-ipmilan-uniq.patch
Type: text/x-patch
Size: 3335 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/linux-cluster/attachments/20120203/8ede2237/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 02-fence-agents-3.1.2-ipmilan-cycle.patch
Type: text/x-patch
Size: 431 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/linux-cluster/attachments/20120203/8ede2237/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 03-fence-agents-3.1.2-ipmilan-wait-time.patch
Type: text/x-patch
Size: 492 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/linux-cluster/attachments/20120203/8ede2237/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 04-fence-agents-3.1.2-ipmilan-optname-typo.patch
Type: text/x-patch
Size: 762 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/linux-cluster/attachments/20120203/8ede2237/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 05-fence-agents-3.1.2-ipmilan-spelling-fix.patch
Type: text/x-patch
Size: 599 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/linux-cluster/attachments/20120203/8ede2237/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 06-fence-agents-3.1.7-ipmilan-reset-method.patch
Type: text/x-patch
Size: 4472 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/linux-cluster/attachments/20120203/8ede2237/attachment-0005.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 07-fence-agents-3.1.2-ipmilan-delay-fix.patch
Type: text/x-patch
Size: 617 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/linux-cluster/attachments/20120203/8ede2237/attachment-0006.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 08-fence-agents-3.1.7-ipmilan-force-ops.patch
Type: text/x-patch
Size: 4758 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/linux-cluster/attachments/20120203/8ede2237/attachment-0007.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 09-fence-agents-3.1.7-ipmilan-status-recheck.patch
Type: text/x-patch
Size: 8627 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/linux-cluster/attachments/20120203/8ede2237/attachment-0008.bin>