[linux-lvm] Re: LVM 2.2 snapshot bug

[Andrea Arcangeli]

On Tue, Nov 07, 2000 at 05:04:20PM +0000, Stephen C. Tweedie wrote:
> The current ext3 includes debugging code to trap invariants which the
> filesystem expects to be guaranteed, and it's entirely possible that
> their over-cautious checking is trapping on such failed writes.  Send
> me an oops and I can deal with it.

I don't have the Oops (I asked for it too) but Rik should have it.

> > > Indeed this is the case. When the block device is read-write
> > > (the is_read_only(blk_dev) is non-true) it tries to replay
> > > the log, even for a read-only mounted FS.
> > 
> > Ok, I agree it's a minor LVM bug, but again I can't see how that minor bug can
> > cause oopses and I think setting ro_bits won't fix the real bug but it will
> > only hide it.
> 
> It's a major bug as far as ext3 is concerned, because filesystem
> recovery is a critical prerequisite for mounting a filesystem, and
> that requires write access.  ext3 has to be able to trust the ro bits
> in order to know whether it is safe to perform recovery writes for a
> mount, or whether the mount must be rejected because recovery cannot
> take place.

Stephen, the floppy device is doing exactly the same thing of LVM.
I don't think it's a major bug. The _only_ downside of the bug is that
it will generate I/O errors when you try to write to the device via
ll_rw_block (no oopses, no corruption), and those I/O errors will happen
anyways in real world too with real harddisk so we must able to cope with them
regardless.

The bug that hurted Rik is ext3 that is not able to deal with I/O error
properly during recovery and if you fix that, then LVM snapshot not setting
ro_bits will be a minor problem IMHO.

Infact I'm not even sure if it worth to have LVM snapshot to set ro_bits
given it will soon become a writeable snapshot (so that we can do recovery
on it too :).

Andrea