[linux-lvm] K=2.4.3 - LVM0.9.1.B7 compiling problem.

[Joe Thornber]

On Wed, Apr 25, 2001 at 03:30:07PM +0100, Patrick Caulfield wrote:
> On Tue, Apr 24, 2001 at 01:09:19PM -0300, Ernesto Silva wrote:
> > 
> > I'm using gcc 2.96 from RedHat 7.0 and I downloaded the tarball.
> > I also applied the patch from the tarball to the kernel.
> > 
> 
> This patch works for me using gcc 3.0:
> 
> 
> Index: lvm_log.h
> ===================================================================
> RCS file: /home/cvs/LVM/tools/lib/lvm_log.h,v
> retrieving revision 1.2
> retrieving revision 1.3
> diff -u -r1.2 -r1.3
> --- lvm_log.h   2001/04/24 14:29:21     1.2
> +++ lvm_log.h   2001/04/25 08:20:57     1.3
> @@ -44,9 +44,9 @@
>  void print_log(int level, const char *format, ...);
>  
>  #define plog(l, f, n, x, a...) print_log(l, "%s:%d " x "\n", f, n, ## a)
> -#define lvm_info(x...) plog(LOG_INFO, __FILE__, __LINE__, "info: " ## x)
> -#define lvm_warn(x...) plog(LOG_WARN, __FILE__, __LINE__, "warning: " ## x)
> -#define lvm_err(x...) plog(LOG_ERROR, __FILE__, __LINE__, "error: " ## x)
> +#define lvm_info(x...) plog(LOG_INFO, __FILE__, __LINE__, "info: " x)
> +#define lvm_warn(x...) plog(LOG_WARN, __FILE__, __LINE__, "warning: " x)
> +#define lvm_err(x...) plog(LOG_ERROR, __FILE__, __LINE__, "error: " x)
>  
>  #define lvm_fatal(x...) do {\
>    plog(LOG_FATAL, __FILE__, __LINE__, "(FATAL) " ## x); \
> 

If this is the right fix (time for me to download gcc 3.0) why haven't you
changed lvm_fatal and plog ?  Does this still do the right thing under older
versions of gcc ?

- Joe