[linux-lvm] Removing direct access to gendisk_head

Christoph Hellwig hch at ns.caldera.de
Sun Oct 7 10:02:26 UTC 2001


On Sat, Oct 06, 2001 at 01:01:47PM +0200, Jan-Benedict Glaw wrote:
> Hi!
> 
> I'm currently looking over kernel code (for cleaning-up purposes)
> and removed EXPORT_SYMBOL(gendisk_head) which was a no-no for
> current LVM kernel code. Please think about picking up this patch
> 
> 	- Named struct initializers
> 	- Removing direct use of gendisk_head
> 
> There's an open Q: Do we need to nullify ->real_devices and ->next?
> I don't think so (but I am unsure) so please remove these two lines
> upon your oppinion:-)

lvm_gendisk is in bss so it's ok to nullify it - see what I did to
the inkernel LVM :)

	Christoph

-- 
Of course it doesn't work. We've performed a software upgrade.




More information about the linux-lvm mailing list