[linux-lvm] Re: [RFLART] kdev_t in ioctls
Christoph Hellwig
hch at caldera.de
Mon Jan 14 12:09:01 UTC 2002
On Mon, Jan 14, 2002 at 10:01:25AM -0800, Linus Torvalds wrote:
>
> On Mon, 14 Jan 2002, Alexander Viro wrote:
> >
> > Linus, at least some ioctls (e.g. lvm ones) pass kdev_t from/to
> > userland. While the common policy with ioctls is "anything goes", this
> > kind of abuse is IMNSHO over the top.
>
> That's completely bogus.
>
> The good news is that the bit-for-bit representation of old kdev_t and
> "dev_t" are obviously 100% the same, so we should just make the damn thing
> be dev_t, and user land will never notice anything.
Glibc disagrees with you (bits/types.h):
typedef __u_quad_t __dev_t; /* Type of device numbers. */
We'd have to use __kernel_dev_t instead which again pulls kernel
headers in..
Christoph
More information about the linux-lvm
mailing list