[linux-lvm] Patch for vg_status_with_pv_and_lv.c

Dale J. Stephenson dalestephenson at mac.com
Mon Mar 3 12:56:02 UTC 2003


A minor patch to prevent  a possible segfault -- if an error occurs 
getting the lv list, vg_setup_pointers_for_snapshot doesn't do well. 
 Patch was originally generated against 1.0.3, but the bug still seems 
to be in 1.0.6.

--- 1.0.3/tools/lib/vg_status_with_pv_and_lv.c.orig	Thu Apr 11 10:45:18 2002
+++ 1.0.3/tools/lib/vg_status_with_pv_and_lv.c	Thu Apr 11 10:45:41 2002
@@ -57,10 +57,10 @@
       for ( p = 0; pv[p] != NULL; p++) (*vg)->pv[p] = pv[p];
       for ( ; p < (*vg)->pv_max; p++) (*vg)->pv[p] = NULL;
       for ( l = 0; l < (*vg)->lv_max; l++) (*vg)->lv[l] = lv[l];
-   }
 
-   /* Set up core pointers for snapshots */
-   vg_setup_pointers_for_snapshots ( *vg);
+      /* Set up core pointers for snapshots */
+      vg_setup_pointers_for_snapshots ( *vg);
+   }
 
    debug_leave ( "vg_status_with_pv_and_lv -- LEAVING with ret: %d\n", ret);
    return ret;







More information about the linux-lvm mailing list