[linux-lvm] Snapshot resizing memory leak
Heinz J . Mauelshagen
mauelshagen at sistina.com
Tue Mar 4 06:05:02 UTC 2003
Dale,
thanks for finding this one.
Could you please give the LVM version you patched in future posts ?
Regards,
Heinz -- The LVM Guy --
On Mon, Mar 03, 2003 at 01:28:58PM -0800, Dale J. Stephenson wrote:
> It looks like the current lvm code still has the memory leak when
> resizing snapshots. The lv_block_exception and lv_snapshot_hash_table
> fields are set to ones newly allocated for the new size, but the old
> ones are not freed. The following patch should fix it:
>
> --- linux/drivers/md/lvm.c.orig Thu Mar 14 08:21:16 2002
> +++ linux/drivers/md/lvm.c Thu Mar 14 08:23:07 2002
> @@ -2489,6 +2489,8 @@
> memcpy(new_lv->lv_block_exception,
> old_lv->lv_block_exception, size);
>
> + vfree(old_lv->lv_block_exception);
> + vfree(old_lv->lv_snapshot_hash_table);
> old_lv->lv_remap_end = new_lv->lv_remap_end;
> old_lv->lv_block_exception = new_lv->lv_block_exception;
> old_lv->lv_snapshot_hash_table =
>
>
>
>
> _______________________________________________
> linux-lvm mailing list
> linux-lvm at sistina.com
> http://lists.sistina.com/mailman/listinfo/linux-lvm
> read the LVM HOW-TO at http://tldp.org/HOWTO/LVM-HOWTO/
*** Software bugs are stupid.
Nevertheless it needs not so stupid people to solve them ***
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
Heinz Mauelshagen Sistina Software Inc.
Senior Consultant/Developer Am Sonnenhang 11
56242 Marienrachdorf
Germany
Mauelshagen at Sistina.com +49 2626 141200
FAX 924446
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
More information about the linux-lvm
mailing list