[linux-lvm] [RFC][PATCH] proper DESTDIR handling for device-mapper and LVM2

Alasdair G Kergon agk at redhat.com
Tue Mar 16 21:27:36 UTC 2004


On Fri, Mar 12, 2004 at 08:27:43AM -0700, Kevin P. Fleming wrote:
> To keep DESTDIR only in the template, you'll have to replace the
> bindir = @bindir@
> lines (and similar) in make.tmpl with
> bindir = $(DESTDIR)@bindir@
 
Yes.

> what was already in the Makefiles, and even then it would tend to break 
> because /usr/sbin/lvm would end up linked to
> /foo/usr/lib/libdevmapper.so
> instead of
> /usr/lib/libdevmapper.so
> and so /usr/sbin/lvm wouldn't run properly once the DESTDIR directory 
> was used as a real environment.

If this was Solaris, yes, we'd need -R to set the default run-time library
path.  But AFAIK linux only searches LD_LIBRARY_PATH, ld.so.cache
and /usr/lib:/lib.

I still think it's wrong to use the version of any include file found on 
the host system if there is a different version of it present in DESTDIR.
[That copes fine for people installing into an empty directory, 
and AFAICT also caters for people building multiple packages with
dependencies.]

Alasdair
-- 
agk at redhat.com



More information about the linux-lvm mailing list