[linux-lvm] [PATCH LVM2] fix description of lvcreate --regionsize

Jun'ichi Nomura j-nomura at ce.jp.nec.com
Fri Oct 6 21:52:14 UTC 2006


While lvcreate man page says -R|--regionsize takes mirror region
size in "KB", it actually takes the parameter as "MB".
It's inconsistent.

This patch fixes man page to describe it as "MB".

Alternative fix could be change the line for regionsize_ARG in
tools/args.h as follows:
  arg(regionsize_ARG, 'R', "regionsize", size_kb_arg)
Then the command takes the argument as "KB".
This allows user to set smaller region size from command line
but breaks compatibility with older versions.

I'm not sure which one is better.
If someone needs to choose region size smaller than 1MB, you can do it:
# lvcreate --config "activation {mirror_region_size=4}" -m1 -L100M vg

 man/lvcreate.8 |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Jun'ichi Nomura, NEC Corporation of America
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 03.1-lvcreate-regionsize-fix.patch
Type: text/x-patch
Size: 1209 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/linux-lvm/attachments/20061006/e45bb3b4/attachment.bin>

More information about the linux-lvm mailing list