[linux-lvm] [PATCH] lvremove: perform retry logic also on -real subvolume for snapshots

[Christian Seiler]

Hi there,

> One more question - what's the distro you're using? Some distros
> change udev rules or they add completely different ones from upstream
> (for example I know that Debian changes upstream LVM udev rules).

The computer in question is running Debian Squeeze (oldstable) (where
the LVM version was the one that was too old; a system upgrade to Wheezy
is planned but will take a while) and then I compiled the LVM version
that comes with Wheezy (stable) where at least from what I gathered from
the commit mailing archives here both fixes I mentioned in the original
mail are included.

FYI: These are the LVM udev rools that are in the LVM2 package that's
currently installed.

------------------------------------------------------------------
cat /lib/udev/rules.d/56-lvm.rules
# Udev rules for LVM.
# See /usr/share/doc/lvm2/README.udev for further information.

ACTION!="add|change", GOTO="lvm_end"
ENV{DM_UDEV_RULES}=="", GOTO="lvm_end"
ENV{DM_UUID}!="LVM-?*", GOTO="lvm_end"

# Use DM name and split it up into its VG/LV/layer constituents.
IMPORT{program}="/sbin/dmsetup splitname --nameprefixes --noheadings
--rows $env{DM_NAME}"

ENV{DM_UDEV_DISABLE_SUBSYSTEM_RULES_FLAG}!="1", GOTO="lvm_end"

ENV{DM_UDEV_DISABLE_DISK_RULES_FLAG}="1"
ENV{DM_UDEV_DISABLE_OTHER_RULES_FLAG}="1"
OPTIONS:="nowatch"

LABEL="lvm_end"

cat /lib/udev/rules.d/60-persistent-storage-lvm.rules
# Udev rules for LVM.
# See /usr/share/doc/lvm2/README.udev for further information.

ACTION!="add|change", GOTO="persistent_storage_lvm_end"
ENV{DM_UDEV_RULES}=="", GOTO="persistent_storage_lvm_end"
ENV{DM_UUID}!="LVM-?*", GOTO="persistent_storage_lvm_end"

ENV{DM_UDEV_DISABLE_SUBSYSTEM_RULES_FLAG}=="1",
GOTO="persistent_storage_lvm_end"

ENV{DM_VG_NAME}=="?*", ENV{DM_LV_NAME}=="?*", ENV{DM_LV_LAYER}=="",
SYMLINK+="$env{DM_VG_NAME}/$env{DM_LV_NAME}"

LABEL="persistent_storage_lvm_end"
------------------------------------------------------------------

> Or have you tested this with upstream (or Fedora) LVM version?

I will do so once I get the chance. But since it is very likely that the
specific environment here might also contribute to the likelyhood of the
failures occuring, I'll do so not by trying it on a clean Fedora install
but by compiling the current upstream git on the Debian computer in
question.

Christian