[linux-lvm] Minor bugs in LVM

[Ming-Hung Tsai]

2016-01-27 19:11 GMT+08:00 M.H. Tsai <mingnus at gmail.com>:
> 4. Typo in debug message
>
> diff --git a/lib/activate/activate.c b/lib/activate/activate.c
> index 8f5b72b..d7c8e4e 100644
> --- a/lib/activate/activate.c
> +++ b/lib/activate/activate.c
> @@ -1156,7 +1156,7 @@ int lv_thin_pool_transaction_id(const struct
> logical_volume *lv,
>   if (!lv_info(lv->vg->cmd, lv, 1, NULL, 0, 0))
>   return 0;
>
> - log_debug_activation("Checking thin percent for LV %s.",
> + log_debug_activation("Checking thin-pool transaction id for LV %s.",
>       display_lvname(lv));
>
>   if (!(dm = dev_manager_create(lv->vg->cmd, lv->vg->name, 1)))

Hi,

This issue hasn't be completely fixed. The patch 53058e52 still prints
incorrect message.
https://www.redhat.com/archives/lvm-devel/2016-February/msg00015.html

It should be:

diff --git a/lib/activate/activate.c b/lib/activate/activate.c
index 2eb24d4..a3b2379 100644
--- a/lib/activate/activate.c
+++ b/lib/activate/activate.c
@@ -1160,7 +1160,7 @@ int lv_thin_pool_transaction_id(const struct
logical_volume *lv,
        if (!lv_info(lv->vg->cmd, lv, 1, NULL, 0, 0))
                return 0;

-       log_debug_activation("Checking thin-pool percent for LV %s.",
+       log_debug_activation("Checking thin-pool transaction id for LV %s.",
                             display_lvname(lv));

        if (!(dm = dev_manager_create(lv->vg->cmd, lv->vg->name, 1)))


Thanks,
Ming-Hung Tsai