[linux-lvm] pvscan: bugs in manpage and implementation

[Zdenek Kabelac]

Dne 18.9.2017 v 09:52 Tom Hale napsal(a):
> Hi,
> 
> MAN PAGE
> 
> In http://man7.org/linux/man-pages/man8/pvscan.8.html I see the
> following issues:
> 
> * The string "-a--activate" appears several times. Should be:
>    "-a|--activate"
> 
> * "-a|--activate y|n|ay" is mentioned, but later on:
> "Only ay is applicable." Please remove "y|n|".
> 
> PROGRAM
> 
> # pvscan --activate ay
>    Command does not accept option: --activate ay.
> 
> The message is confusing. It would be better to say "--activate requires
> --cache"
> 
> In fact, why not drop the "ay" argument all together and just allow
> "--cache --activate"?

Hi

In general - we use internal logic for parsing options and its parameters and 
in this case the options 'takes' more parameters then 'pvscan' can accept.

We could possibly add 'extra' special  option  e.i. :
--pvscanautoactivation

but we've considered at given time it's not worth since normally no user is 
ever supposed to use it in regular user space (since noone likes to see more 
and more individal options doing nearly the same thing)

This option is mostly targeted for execution inside  udev rules  - and since 
there was some 'evolution' how to make this working - it's now not really 
worth to make it more complicated - since we would have to keep old option 
present anyway for backward compatibility.

Regards

Zdenek