[linux-lvm] resend patch - bcache may mistakenly write data to another disk when writes error
Joe Thornber
thornber at redhat.com
Tue Oct 29 14:41:28 UTC 2019
On Tue, Oct 29, 2019 at 11:47:19AM +0000, Heming Zhao wrote:
> You are right. I forgot the radix_tree_remove_prefix().
> The radix_tree_remove_prefix() is called both bcache_invalidate_fd & bcache_abort_fd.
> So the job will not work as expected in bcache_abort_fd, because the node is already removed.
> Please correct me if my thinking is wrong.
Slightly wrong, the remove_prefix in invalidate should only be running if it.success is true.
Well spotted.
- Joe
More information about the linux-lvm
mailing list