[linux-lvm] [PATCH] lvdisplay: dispaly partial when underlying devs missing
Zhao Heming
heming.zhao at suse.com
Wed Aug 19 04:15:58 UTC 2020
After removing LV underlying dev, lvdisplay still display 'available'.
With this patch, lvdisplay will show
from:
LV Status available
to:
LV Status NOT available (partial)
reproducible steps:
1. vgcreate vg1 /dev/sda /dev/sdb
2. lvcreate --type raid0 -l 100%FREE -n raid0lv vg1
3. do remove the /dev/sdb action
4. lvdisplay show wrong 'LV Status'
Signed-off-by: Zhao Heming <heming.zhao at suse.com>
---
lib/display/display.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/lib/display/display.c b/lib/display/display.c
index 36c9879b3..6c895c820 100644
--- a/lib/display/display.c
+++ b/lib/display/display.c
@@ -399,7 +399,7 @@ int lvdisplay_full(struct cmd_context *cmd,
void *handle __attribute__((unused)))
{
struct lvinfo info;
- int inkernel, snap_active = 0;
+ int inkernel, snap_active = 0, partial = 0;
char uuid[64] __attribute__((aligned(8)));
const char *access_str;
struct lv_segment *snap_seg = NULL, *mirror_seg = NULL;
@@ -555,9 +555,13 @@ int lvdisplay_full(struct cmd_context *cmd,
if (inkernel && info.suspended)
log_print("LV Status suspended");
- else if (activation())
- log_print("LV Status %savailable",
- inkernel ? "" : "NOT ");
+ else if (activation()) {
+ if (lv->status & PARTIAL_LV)
+ partial = 1;
+ log_print("LV Status %savailable %s",
+ (inkernel && !partial) ? "" : "NOT ",
+ partial ? "(partial)" : "");
+ }
/********* FIXME lv_number
log_print("LV # %u", lv->lv_number + 1);
--
2.27.0
More information about the linux-lvm
mailing list