[linux-lvm] Frequent crashes when accessing dev_name(dev) on an empty list

Konstantin Kharlamov hi-angel at yandex.ru
Mon Feb 21 17:35:07 UTC 2022


On Mon, 2022-02-21 at 10:49 -0600, David Teigland wrote:
> On Mon, Feb 21, 2022 at 04:45:51PM +0300, Konstantin Kharlamov wrote:
> > So, what happened was that dev_name(dev) was extracting a `dev->aliases`
> > element
> > , however `dev->aliases` was empty, thus the extracted element was a junk.
> > 
> > Although we encountered these crashes on an older 2.03.07 version, however
> > the
> > patch applies to latest master as well, thus the bugs are still relevant,
> > which
> > is odd. This makes me wondering, is this a known problem, could I possibly
> > overlooked something, for example that dev->aliases should never be empty,
> > and
> > thus the fix just works around another problem? Any thoughts?
> 
> It's familiar, but I thought it was fixed.  I don't remember the details,
> so we'll have to look at it again.  It's related to a device being removed
> from the system while the command is running, which we need to add tests
> for.

Okay, thank you, so I guess the conclusion is that before anything else we need to reproduce it with the latest version.





More information about the linux-lvm mailing list