[lvm-devel] [PATCH] Cleanup partial failure of activation

[Alasdair G Kergon]

On Wed, Nov 21, 2007 at 11:00:03AM -0500, Jun'ichi Nomura wrote:
> If activate_lv() fails, callers won't call deactivate_lv().
> However, activate_lv() may succeeded activation partially.
 
> Attached patch deactivates a partially activated LV so that
> callers of activate_lv() don't need to care about partial failure.

But could the deactivation call deactivate something that was active *before*
it was called?  Are you sure this will always accurately return things to the
state they were in prior to the failed call, and not deactivate something that
was previously active?

Alasdair
-- 
agk at redhat.com