[lvm-devel] [PATCH 06/11] Remove archive_enable() calls after create_toolcontext() calls.
Dave Wysochanski
dwysocha at redhat.com
Thu Dec 11 02:20:39 UTC 2008
On Wed, 2008-12-10 at 22:41 +0000, Alasdair G Kergon wrote:
> On Wed, Dec 10, 2008 at 01:10:56PM -0500, Dave Wysochanski wrote:
> > The archive_enable() call we remove
> > here was using cmd->current_settings to set the 'archive' enable
> > value.
>
> Does that make archive_enable() unused?
>
it's called from _apply_settings() too.
> > - if (!archive_init(cmd, dir, days, min)) {
> > + if (!archive_init(cmd, dir, days, min,
> > + cmd->default_settings.archive)) {
>
> Call archive_enable() here instead, or have archive_init() call it
> internally or comment out the function as unused?
>
I can call it internally.
More information about the lvm-devel
mailing list