[lvm-devel] [PATCH] New lib/lvm2.c for base library functions
Alasdair G Kergon
agk at redhat.com
Fri Dec 12 01:11:09 UTC 2008
On Thu, Dec 11, 2008 at 05:43:41PM +0100, Thomas Woerner wrote:
> lib/lvm2.c | 42 ++++++++++++++++++++++++++++++++++++++++++
I'd prefer not to have a 'special' file like that.
Please place the functions elsewhere in the directory
hierachy according to what they are doing.
> +lvm2_handle_t lvm2_create(const char *sys_dir)
> +{
> + struct cmd_context *cmd;
> +
> + /* use internal version with system_dir */
> + cmd = create_librarycontext(sys_dir);
No need for this wrapper at this stage - just use the main function directly!
(And make sure the files in the tools directory use these functions as part of
the same patch.)
> +void lvm2_destroy(lvm2_handle_t libh)
...
> + return 1;
:-)
Alasdair
--
agk at redhat.com
More information about the lvm-devel
mailing list