[lvm-devel] [PATCH] (1/2) new library interface for vg_read

Alasdair G Kergon agk at redhat.com
Fri Dec 12 01:42:12 UTC 2008


On Thu, Dec 11, 2008 at 03:39:07PM -0500, Dave Wysochanski wrote:
> On Tue, 2008-12-09 at 17:44 +0100, Petr Rockai wrote:
> > +++ new-lvmlib/lib/device/dev-io.c      2008-12-09 17:44:06.930396980
> > +0100
> > @@ -622,6 +622,11 @@ int dev_write(struct device *dev, uint64

> > +       if (!vg_write_lock_held()) {
> > +               log_error("Attempted to write unlocked VG's device.");
> > +               return_0;

If the code was correct that never would happen?
i.e. Label it as 'Internal error:'

Alasdair
-- 
agk at redhat.com




More information about the lvm-devel mailing list