[lvm-devel] LVM2/lib/metadata mirror.c

agk at sourceware.org agk at sourceware.org
Wed Jan 16 19:38:39 UTC 2008


CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	agk at sourceware.org	2008-01-16 19:38:39

Modified files:
	lib/metadata   : mirror.c 

Log message:
	cope with stacked LVs as well as PVs when deciding which bits of mirrors to remove

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/metadata/mirror.c.diff?cvsroot=lvm2&r1=1.57&r2=1.58

--- LVM2/lib/metadata/mirror.c	2008/01/16 19:18:51	1.57
+++ LVM2/lib/metadata/mirror.c	2008/01/16 19:38:39	1.58
@@ -347,9 +347,12 @@
 
 	list_iterate_items(seg, &mimage_lv->segments) {
 		for (s = 0; s < seg->area_count; s++) {
-			if (seg_type(seg, s) != AREA_PV)
-				/* FIXME Recurse for AREA_LV */
-				continue;
+			if (seg_type(seg, s) != AREA_PV) {
+				/* FIXME Recurse for AREA_LV? */
+				/* Structure of seg_lv is unknown.
+				 * Not removing this LV for safety. */
+				return 0;
+			}
 
 			pv = seg_pv(seg, s);
 




More information about the lvm-devel mailing list