[lvm-devel] [PATCH] fix cmd->cmd_line memory pool use
Milan Broz
mbroz at redhat.com
Thu Apr 2 14:19:47 UTC 2009
Do not use pointer from released memory pool (cmd->cmd_line).
Signed-off-by: Milan Broz <mbroz at redhat.com>
---
tools/lvmcmdline.c | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/tools/lvmcmdline.c b/tools/lvmcmdline.c
index a96ef3c..bedf9e2 100644
--- a/tools/lvmcmdline.c
+++ b/tools/lvmcmdline.c
@@ -1026,16 +1026,16 @@ int lvm_run_command(struct cmd_context *cmd, int argc, char **argv)
cmd->current_settings = cmd->default_settings;
_apply_settings(cmd);
- /*
- * free off any memory the command used.
- */
- dm_pool_empty(cmd->mem);
-
if (ret == EINVALID_CMD_LINE && !_cmdline.interactive)
_short_usage(cmd->command->name);
log_debug("Completed: %s", cmd->cmd_line);
+ /*
+ * free off any memory the command used.
+ */
+ dm_pool_empty(cmd->mem);
+
return ret;
}
More information about the lvm-devel
mailing list