[lvm-devel] [PATCH v2] Enable use of cached metadata for pvs & pvdisplay
Milan Broz
mbroz at redhat.com
Wed Apr 8 10:50:47 UTC 2009
Takahiro Yasui wrote:
>> @@ -778,12 +785,19 @@ int process_each_pv(struct cmd_context *cmd, int argc, char **argv,
>> if (ret > ret_max)
>> ret_max = ret;
>> if (sigint_caught())
>> - return ret_max;
>> + goto bad;
>
> In the above line, "goto bad" is typo of "goto out"?
hm. you are right, I thought that signal interruption should return ECMD_FAIL but apparently
reporting code do not use that.
We should probably define something like ECMD_INTERRUPTED and use that... but it is unrelated problem.
If Alasdair acks that, I fix it in real commit.
Milan
More information about the lvm-devel
mailing list