[lvm-devel] LVM2/lib/metadata mirror.c

mornfall at sourceware.org mornfall at sourceware.org
Thu Apr 23 16:43:02 UTC 2009


CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	mornfall at sourceware.org	2009-04-23 16:43:01

Modified files:
	lib/metadata   : mirror.c 

Log message:
	A more thorough PV equality test (that also copes better with MISSING_PVs) in
	_is_mirror_image_removable.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/metadata/mirror.c.diff?cvsroot=lvm2&r1=1.84&r2=1.85

--- LVM2/lib/metadata/mirror.c	2009/04/21 14:31:58	1.84
+++ LVM2/lib/metadata/mirror.c	2009/04/23 16:43:01	1.85
@@ -440,7 +440,12 @@
 
 			pv_found = 0;
 			dm_list_iterate_items(pvl, removable_pvs) {
-				if (pv->dev->dev == pvl->pv->dev->dev) {
+				if (id_equal(&pv->id, &pvl->pv->id)) {
+					pv_found = 1;
+					break;
+				}
+				if (pvl->pv->dev && pv->dev &&
+				    pv->dev->dev == pvl->pv->dev->dev) {
 					pv_found = 1;
 					break;
 				}




More information about the lvm-devel mailing list