[lvm-devel] [PATCH 1 of 4] Add more error codes in mirror DSO
malahal at us.ibm.com
malahal at us.ibm.com
Fri Dec 18 17:01:19 UTC 2009
Jonathan Brassow [jbrassow at redhat.com] wrote:
> Is there a reason you bumped ME_IGNORE from 0 to 1?
It is actually a bit-field value rather than an absolute value, so I
couldn't have anything with zero.
> Did you forget about ME_IGNORE in 'process_event' (causing it to fall
> through to the final else)?
Yes! Thank you. Unknown errors are handled as 'fatal' errors in the
existing code, so process_event will never get an unknown error code (it
has to be ME_IGNORE). I will fix it.
More information about the lvm-devel
mailing list