[lvm-devel] [PATCH 4/11] Add vg_read_error and vg_might_exist.
Alasdair G Kergon
agk at redhat.com
Mon Jan 12 22:16:01 UTC 2009
On Mon, Jan 12, 2009 at 03:07:59PM +0100, Peter Rockai wrote:
> +uint32_t vg_read_error(vg_t *vg) {
{ on new line please.
Again, I suggest using a typedef for the return value.
> + if (!vg)
> + return FAILED_ALLOCATION;
> + if (vg->read_failed & EXISTENCE_CHECK)
> + return vg->read_failed & ~(EXISTENCE_CHECK | FAILED_NOTFOUND);
> + return vg->read_failed;
> +}
Let's explain that logic in a description above the function (or in the .h file
where the FAILED* are defined).
- Why are some combinations valid in some parts of the code but not in others?
- Is the EXISTENCE_CHECK part obfuscation that could be done more cleanly?
> +/* Queries on a (possibly error-indicating) VG handle. */
> +uint32_t vg_read_error(vg_t *vg);
> +uint32_t vg_might_exist(vg_t *vg);
Explain what the uint32_t returned means. (Or use a typedef which should be
self-documenting.)
Alasdair
--
agk at redhat.com
More information about the lvm-devel
mailing list