[lvm-devel] [PATCH 1/2] remove floating point values from lvm

Jonathan Brassow jbrassow at redhat.com
Fri Jan 23 19:33:18 UTC 2009


I like the idea of getting rid of the floating point return value, but  
do we really have to introduce the 4 new return values?

  brassow

On Jan 21, 2009, at 9:57 AM, Mikulas Patocka wrote:

> Avoid depending on comparison of floating-point values. Return 4  
> values:
> TARGET_STATUS_ERROR --- error occured
> TARGET_STATUS_INVALIDATED --- the snapshot is invalidated (there may  
> still exist
> 	100% filled snapshot that is not invalidated)
> TARGET_STATUS_PROCESSING --- mirror is resynchronizing, snapshot is  
> neither
> 	empty nor invalidated.
> TARGET_STATUS_FINISHED --- finished. For mirrors, it is returned  
> when the mirror
> 	resynchronization finished. For snapshots, it is returned when the
> 	snapshot contains no exceptions (merging finished).
>
> Decisions are made based on these returned values, not on actual  
> floating point
> number.




More information about the lvm-devel mailing list