[lvm-devel] [PATCH] Fix leaked config override mempool.
Milan Broz
mbroz at redhat.com
Wed Jul 15 13:22:02 UTC 2009
Fix leaked config override mempool.
pvs --config 'global { units = "<" }'
Invalid units specification
Updated config file invalid. Aborting.
causes in old code
Segmentation fault
and now memory leak :-)
Fix it by properly releasing overrided config in lvm_run_command
if refresh_toolcontext() fails.
Signed-off-by: Milan Broz <mbroz at redhat.com>
---
tools/lvmcmdline.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/tools/lvmcmdline.c b/tools/lvmcmdline.c
index 10cbb12..f756a0f 100644
--- a/tools/lvmcmdline.c
+++ b/tools/lvmcmdline.c
@@ -993,7 +993,8 @@ int lvm_run_command(struct cmd_context *cmd, int argc, char **argv)
/* Reinitialise various settings inc. logging, filters */
if (!refresh_toolcontext(cmd)) {
log_error("Updated config file invalid. Aborting.");
- return ECMD_FAILED;
+ ret = ECMD_FAILED;
+ goto out;
}
}
More information about the lvm-devel
mailing list