[lvm-devel] [PATCH 2/6] Add devices/data_alignment_offset_detection to lvm.conf.
Milan Broz
mbroz at redhat.com
Thu Jul 16 18:47:40 UTC 2009
Mike Snitzer wrote:
> + if (dm_snprintf(path, PATH_MAX, "%s/dev/block/%d:%d/%s",
> + sysfs_dir, MAJOR(dev->dev), MINOR(dev->dev),
> + attribute) < 0) {
> + log_error("dm_snprintf %s failed", attribute);
> + return 0;
> + }
>
>
this segfaults here on 32bit...
---
lib/device/device.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/device/device.c b/lib/device/device.c
index 2d01ec8..5330e3c 100644
--- a/lib/device/device.c
+++ b/lib/device/device.c
@@ -296,7 +296,7 @@ int primary_dev(const char *sysfs_dir,
/* check if dev is a partition */
if (dm_snprintf(path, PATH_MAX, "%s/dev/block/%d:%d/partition",
- sysfs_dir, MAJOR(dev->dev), MINOR(dev->dev)) < 0) {
+ sysfs_dir, (int)MAJOR(dev->dev), (int)MINOR(dev->dev)) < 0) {
log_error("dm_snprintf partition failed");
return ret;
}
@@ -366,7 +366,7 @@ static unsigned long _dev_topology_attribute(const char *attribute,
return_0;
if (dm_snprintf(path, PATH_MAX, sysfs_fmt_str, sysfs_dir,
- MAJOR(dev->dev), MINOR(dev->dev),
+ (int)MAJOR(dev->dev), (int)MINOR(dev->dev),
attribute) < 0) {
log_error("dm_snprintf %s failed", attribute);
return 0;
More information about the lvm-devel
mailing list