[lvm-devel] [PATCH] Update vg_create to use lvm_errno and return NULL upon error.
Dave Wysochanski
dwysocha at redhat.com
Wed Jul 22 20:16:21 UTC 2009
On Wed, 2009-07-22 at 15:52 -0400, Dave Wysochanski wrote:
> We must update vgsplit and vgcreate at the same time or we break the
> nightly tests.
>
> Signed-off-by: Dave Wysochanski <dwysocha at redhat.com>
> ---
> index 35c425a..158a532 100644
> --- a/tools/vgsplit.c
> +++ b/tools/vgsplit.c
> @@ -264,7 +264,7 @@ int vgsplit(struct cmd_context *cmd, int argc, char **argv)
> log_verbose("Checking for new volume group \"%s\"", vg_name_to);
> /*
> * First try to create a new VG. If we cannot create it,
> - * and we get FAILED_EXIST (we will not be holding a lock),
> + * and we get EEXIST (we will not be holding a lock),
> * a VG must already exist with this name. We then try to
> * read the existing VG - the vgsplit will be into an existing VG.
> *
> @@ -273,15 +273,12 @@ int vgsplit(struct cmd_context *cmd, int argc, char **argv)
> * system. Thus, the split will be into a new VG.
> */
> vg_to = vg_create(cmd, vg_name_to);
> - if (vg_read_error(vg_to) == FAILED_LOCKING) {
> - log_error("Can't get lock for %s", vg_name_to);
> - vg_release(vg_to);
> + if (!vg_to && stored_errno() != EXIST) {
This is a silly typo - should be EEXIST. I corrected this error in my
local repo and verified testsuite passes.
More information about the lvm-devel
mailing list