[lvm-devel] [PATCH] Refactor _override_settings to take the new config string as input.
Dave Wysochanski
dwysocha at redhat.com
Mon Jul 27 20:01:45 UTC 2009
We will re-use this function from liblvm.
Signed-off-by: Dave Wysochanski <dwysocha at redhat.com>
---
tools/lvmcmdline.c | 7 ++++---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/tools/lvmcmdline.c b/tools/lvmcmdline.c
index 81adfce..3ca75a7 100644
--- a/tools/lvmcmdline.c
+++ b/tools/lvmcmdline.c
@@ -887,9 +887,9 @@ int help(struct cmd_context *cmd __attribute((unused)), int argc, char **argv)
return ret;
}
-static int _override_settings(struct cmd_context *cmd)
+static int _override_settings(struct cmd_context *cmd, const char *config_settings)
{
- if (!(cmd->cft_override = create_config_tree_from_string(cmd, arg_str_value(cmd, config_ARG, "")))) {
+ if (!(cmd->cft_override = create_config_tree_from_string(cmd, config_settings))) {
log_error("Failed to set overridden configuration entries.");
return EINVALID_CMD_LINE;
}
@@ -986,7 +986,8 @@ int lvm_run_command(struct cmd_context *cmd, int argc, char **argv)
set_cmd_name(cmd->command->name);
if (arg_count(cmd, config_ARG))
- if ((ret = _override_settings(cmd)))
+ if ((ret = _override_settings(cmd,
+ arg_str_value(cmd, config_ARG, ""))))
goto_out;
if (arg_count(cmd, config_ARG) || !cmd->config_valid || config_files_changed(cmd)) {
--
1.6.0.6
More information about the lvm-devel
mailing list