[lvm-devel] [PATCH] fix question if lvconverting to core log

Milan Broz mbroz at redhat.com
Wed Mar 25 13:33:50 UTC 2009


yes_no_prompt returns 'n' or 'y'...

Why we require this always? My test case is that PV with log
fails.
Why it need resync before conversion to core log for
inactive mirror?

Signed-off-by: Milan Broz <mbroz at redhat.com>

diff --git a/lib/metadata/mirror.c b/lib/metadata/mirror.c
index 304a8d9..8299c4d 100644
--- a/lib/metadata/mirror.c
+++ b/lib/metadata/mirror.c
@@ -1222,7 +1222,7 @@ int remove_mirror_log(struct cmd_context *cmd,
 		return 0;
 	} else if (yes_no_prompt("Full resync required to convert "
 				 "inactive mirror %s to core log. "
-				 "Proceed? [y/n]: "))
+				 "Proceed? [y/n]: ") == 'y')
 		sync_percent = 0;
 	else
 		return 0;





More information about the lvm-devel mailing list