[lvm-devel] [PATCH 7/7] Remove import paramater from lv_create_empty.
Petr Rockai
prockai at redhat.com
Mon May 11 06:15:35 UTC 2009
Milan Broz <mbroz at redhat.com> writes:
> Now the max_lv check is performed in vg_add_lv and import parameter in
> lv_create_empty has no use.
Indeed -- and good riddance, too.
> Patch also adds simple max_lv tests into testsuite
Good.
> Signed-off-by: Milan Broz <mbroz at redhat.com>
Acked-By: Petr Rockai <prockai at redhat.com>
> - if (!import)
> + if (status & VISIBLE_LV)
> log_verbose("Creating logical volume %s", name);
Would it make sense to use lv_is_visible there? It's just a verbose log
message, so I guess it wouldn't matter much?
Yours,
Petr.
--
Peter Rockai | me()mornfall!net | prockai()redhat!com
http://blog.mornfall.net | http://web.mornfall.net
"In My Egotistical Opinion, most people's C programs should be
indented six feet downward and covered with dirt."
-- Blair P. Houghton on the subject of C program indentation
More information about the lvm-devel
mailing list