[lvm-devel] [PATCH 01/11] debian: fix library search path in example.conf

Fabio M. Di Nitto fdinitto at redhat.com
Tue Nov 10 05:26:59 UTC 2009


Fabio M. Di Nitto wrote:
> Alasdair G Kergon wrote:
>> On Mon, Oct 12, 2009 at 06:02:05AM +0200, Fabio M. Di Nitto wrote:
>>> On Sun, 2009-10-11 at 22:23 +0200, Bastian Blank wrote:
>>>> Its currently unused. The cluster locking lib was the only used external
>>>> lib.
>>  
>>> Alasdair, given that cluster locking lib is gone, do we have a use case
>>> to keep this option configurable? 
>> It's used for all lvm2 external libraries and needs to stay.  The
>> commented-out example is only worth making configurable if people are
>> actually installing libraries into private directories (and arguably it
>> should then be hard-coded into the source too).
>>
>> We only stopped building the cluster locking library externally on Red
>> Hat distributions because of some complexities of the Red Hat build
>> system.  If they get resolved (as I hope they will be with RHEL6) then
>> we will probably reinstate it.  
>>
> 
> The patch in attachment:
> - allows lvm2libdir to be configurable
> - dynamically update docs and man pages
> - changes get_shared_library_path to understand LVM2_LIB_DIR
> - make get_shared_library_path returns error (void to int)
> - update get_shared_library_path users
> 
> Fabio
> 
> 

I just realized that the patch doesn´t show properly the rename of
doc/example.conf to doc/example.conf.in. Just a minor detail.

Fabio




More information about the lvm-devel mailing list