[lvm-devel] [PATCH] Optionally abort on internal errors.
Milan Broz
mbroz at redhat.com
Sun Nov 29 20:34:11 UTC 2009
On 11/29/2009 08:26 PM, Petr Rockai wrote:
> a fairly straightforward patch adding a configure option that will
> abort() the process in case it encounters an internal
> error. Undocumented so far and not sure it's appropriate to expose --
> but maybe we have a policy of no undocumented options?
I like that idea, very useful for test suite.
ACK from me.
just some nitpicking changes like
+ if (level <= _LOG_ERR && !strncmp(format, "Internal error:",
+ strlen("Internal error:")))
(why strlen? just len or better #define the string)
- should it be in log section (global?)
- maybe only activate that when in debug (verbose mode)?
Milan
More information about the lvm-devel
mailing list