[lvm-devel] LVM2/tools vgsplit.c
wysochanski at sourceware.org
wysochanski at sourceware.org
Wed Sep 2 21:27:06 UTC 2009
CVSROOT: /cvs/lvm2
Module name: LVM2
Changes by: wysochanski at sourceware.org 2009-09-02 21:27:06
Modified files:
tools : vgsplit.c
Log message:
Refactor vgsplit: _vgsplit_from or _vgsplit_to failure cleanup depends on order.
Should be no functional change.
Author: Dave Wysochanski <dwysocha at redhat.com>
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/vgsplit.c.diff?cvsroot=lvm2&r1=1.90&r2=1.91
--- LVM2/tools/vgsplit.c 2009/09/02 21:26:50 1.90
+++ LVM2/tools/vgsplit.c 2009/09/02 21:27:05 1.91
@@ -315,8 +315,11 @@
}
vg_from = _vgsplit_from(cmd, vg_name_from);
- if (!vg_from)
+ if (!vg_from) {
+ if (!lock_vg_from_first)
+ unlock_and_release_vg(cmd, vg_to, vg_name_to);
return ECMD_FAILED;
+ }
/*
* Set metadata format of original VG.
@@ -327,7 +330,8 @@
vg_to = _vgsplit_to(cmd, vg_name_to, &existing_vg);
if (!vg_to) {
- unlock_and_release_vg(cmd, vg_from, vg_name_from);
+ if (lock_vg_from_first)
+ unlock_and_release_vg(cmd, vg_from, vg_name_from);
return ECMD_FAILED;
}
if (existing_vg) {
More information about the lvm-devel
mailing list