[lvm-devel] [PATCH] LVM2: Proposal #2 to fix bug 586021

[Alasdair G Kergon]

On Mon, Apr 26, 2010 at 04:44:47PM -0500, Jon Brassow wrote:
> This patch - in contrast to the first proposal - takes the approach that
> the behavior to remove images from a mirror that were not specified when
> a list of PVs was given is wrong.  The code was not adequately prepared
> for this behavior change and was therefore buggy.  This patch tries to
> keep the behavior change and clean-up the bugs.
 
The problem with this approach is that the user has then to include
*all* extents covered by the mimages being removed, and *no* extents
covered by mimages not to be removed.  (Hybrids turn out just as
awkward.)

No problem when you have one mimage per PV, but as soon as you've got
more complex layouts this form of syntax becomes much less forgiving
and harder to use and understand than proposal #1 IMHO.

Alasdair